Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove history dialog override so clicking "Start playing in the background" would play only enqueue the current item instead of the full history #11695

Closed

Conversation

codyit
Copy link
Contributor

@codyit codyit commented Nov 12, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Holding an item in history and clicking "Start playing in the background" would now only add the current item in the play queue, instead of the full history which is usually massive.

Before/After Screenshots/Screen Record

N/A

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

…ground" would play only enqueue the current item instead of the full history
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 12, 2024
@codyit codyit closed this Nov 12, 2024
@codyit codyit deleted the history-remove-dialog-override branch November 12, 2024 05:27
@opusforlife2
Copy link
Collaborator

@codyit ?

@Stypox
Copy link
Member

Stypox commented Nov 16, 2024

@opusforlife2 see #11696

@opusforlife2
Copy link
Collaborator

Ah, got it. @codyit Make sure you leave a comment explaining why the PR was closed. Otherwise future visitors are left confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants